diff --git a/backend/src/main/java/io/dataease/controller/panel/server/StoreServer.java b/backend/src/main/java/io/dataease/controller/panel/server/StoreServer.java index 270c153980..24073a2b52 100644 --- a/backend/src/main/java/io/dataease/controller/panel/server/StoreServer.java +++ b/backend/src/main/java/io/dataease/controller/panel/server/StoreServer.java @@ -26,12 +26,7 @@ public class StoreServer implements StoreApi { } @Override - public void remove(String storeId) { - try { - Long id = Long.parseLong(storeId); - storeService.remove(id); - } catch (Exception e) { - storeService.removeByPanelId(storeId); - } + public void remove(String panelId) { + storeService.removeByPanelId(panelId); } } diff --git a/backend/src/main/java/io/dataease/service/panel/StoreService.java b/backend/src/main/java/io/dataease/service/panel/StoreService.java index 9d3dbd3bae..de25085f3c 100644 --- a/backend/src/main/java/io/dataease/service/panel/StoreService.java +++ b/backend/src/main/java/io/dataease/service/panel/StoreService.java @@ -34,14 +34,15 @@ public class StoreService { } public void removeByPanelId(String panelId) { + Long userId = AuthUtils.getUser().getUserId(); PanelStoreExample panelStoreExample = new PanelStoreExample(); - panelStoreExample.createCriteria().andPanelGroupIdEqualTo(panelId); + panelStoreExample.createCriteria().andPanelGroupIdEqualTo(panelId).andUserIdEqualTo(userId); panelStoreMapper.deleteByExample(panelStoreExample); } - public void remove(Long storeId) { + /*public void remove(Long storeId) { panelStoreMapper.deleteByPrimaryKey(storeId); - } + }*/ /** * 按照当前用户ID查询收藏仪表板 diff --git a/frontend/src/views/panel/enshrine/index.vue b/frontend/src/views/panel/enshrine/index.vue index 795e995e5f..8a2f1449da 100644 --- a/frontend/src/views/panel/enshrine/index.vue +++ b/frontend/src/views/panel/enshrine/index.vue @@ -67,7 +67,7 @@ export default { return data }, remove(row) { - deleteEnshrine(row.storeId).then(res => { + deleteEnshrine(row.panelGroupId).then(res => { this.initData() this.panelInfo && this.panelInfo.id && row.panelGroupId === this.panelInfo.id && this.setMainNull() })